Abort instead of panic on asserting intrinsics #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Mar 18, 2020
RalfJung
reviewed
Mar 18, 2020
RalfJung
reviewed
Mar 18, 2020
elichai
force-pushed
the
2020-03-abort-intrinsics
branch
from
5cd706e
to
7590785
Compare
elichai
commented
Mar 18, 2020
RalfJung
reviewed
Mar 18, 2020
|
I edited your original message to say "fixes #1222" (not "solves") so that GH will close that issue automatically when the PR gets merged. |
elichai
force-pushed
the
2020-03-abort-intrinsics
branch
from
7590785
to
0826899
Compare
|
Looking good, thanks. :) |
|
📌 Commit 0826899 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1222
replacing the panic with an abort and a corresponding message.
the stack trace is already printed, this just adds an optional message the caller can pass, and I just pass the same message we passed to the panic but now to the abort instead.
r? @RalfJung